Clarify behaviour of embedded IpcSenders and IpcReceivers#389
Open
glyn wants to merge 6 commits intoservo:mainfrom
Open
Clarify behaviour of embedded IpcSenders and IpcReceivers#389glyn wants to merge 6 commits intoservo:mainfrom
glyn wants to merge 6 commits intoservo:mainfrom
Conversation
glyn
force-pushed
the
clarify-embedded-behaviour
branch
from
f0453cf to
642c8b3
Compare
See the previous commit for why this testcase is dead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been trying to understand the behaviour of embedded IpcSenders and (especially) IpcReceivers. I offer this PR as clarification of the current behaviour. Whether the current behaviour is intended or not, I hope to learn via this PR (both from review and Windows CI, as I don't have access to a Windows system).
The PR deletes a testcase which doesn't seem to achieve anything useful, although I haven't checked the git history to see if it used to achieve anything useful.