Postcard remove default embedded dependencies#440
Conversation
Narfinger
changed the title
don't need this in our case and can remove it saving a couple of dependencies. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Narfinger
changed the title
|
@Narfinger: the CI failure is opaque to me. Any ideas? |
Narfinger
force-pushed
the
postcard-feature
branch
from
cc8f3a1 to
e484b98
Compare
|
Let me try to restart it and see how it goes. |
|
Still errors. I am not sure why. |
Since there are no details, I suggest running the tests on a Windows box/VM (shudder) or else commenting out the failing tests and seeing if the other Windows jobs give us some clues. |
|
Another option might be to grab the logs using the gh CLI as per https://github.com/orgs/community/discussions/53164#discussioncomment-10569630 (also the whole discussion is about a similar issue). (I wonder if the transitive dependencies on Windows turn out to be a problem?) |
Narfinger
force-pushed
the
postcard-feature
branch
from
0c65aaa to
e484b98
Compare
|
Ok the jobs are doing things now. Looked like a fluke. |
|
What do we make of the outstanding CI failure(s)? Do we write them off and attribute them to some kind of infrastructure glitch? |
Yes |
Since ipc-channel switched, do the same here. Rationale for ipc-channel switching: servo/ipc-channel#432 (comment) See also: servo/ipc-channel#440
4 participants
Postcard is aimed at embedded devices, so has things like heapless in it. We can save these dependencies for our purposes and just rely on the std feature flag.
Signed-off-by: Narfinger Narfinger@users.noreply.github.com