Skip to content

fix xml elements namespace and sharedString/styles file search - #46

Open
dorym wants to merge 1 commit into
sestegra:masterfrom
dorym:fix-xml-namespace-and-files
Open

fix xml elements namespace and sharedString/styles file search#46
dorym wants to merge 1 commit into
sestegra:masterfrom
dorym:fix-xml-namespace-and-files

Conversation

@dorym

@dorym dorym commented Apr 12, 2023

Copy link
Copy Markdown

This fixes 2 things:

  • I encountered some spreadsheets that have namespaces in their xml tags.
    This sets the default lookup for any namespace.
  • styles and shareStrings file paths are concatenated in a wrong way where is some
    cases the given path in workbook.xml.rels is absolute.
    I used the same solution in _parseTable(). It may be useful to extract this logic.

@sestegra

Copy link
Copy Markdown
Owner

Thank you for this PR.
Can you add a test file and a test case for it?

@sestegra sestegra added the bug label Apr 16, 2023
@sestegra

Copy link
Copy Markdown
Owner

@dorym To merge the PR, a test file and its related test case are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants