Use PGlite by default for type generation - #62
Open
stantheman0128 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
db:generatecurrently scaffolds a plainpgstrap generatecommand, which defaults to an external Postgres connection even though the PGlite implementation is already available. This makes PGlite the default in both the CLI and programmatic generator.--no-pgliteandpglite: falseretain explicit generation from an existing database.The existing integration test now checks both the default and explicitly enabled PGlite paths, including generated type and SQL files. The README explains migration-based generation, external-database selection, and the Node 20+ runtime used for CLI validation.
Validation in an isolated Linux environment with Bun 1.3.9:
ECONNREFUSEDagainst an unavailable external Postgres endpoint.bun testpasses all 4 tests;bun run build(including declarations) andbun run format:checkpass.bun run db:generateproducesschema.d.tsandtable.sqlfrom a fixture migration with no external Postgres server. A separate--no-pglitecheck attempts the configured unavailable external endpoint as expected.Implemented and tested with OpenAI Codex assistance.
Fixes #2
@algora-pbc /claim #2