Make EncodedEvent.cls optional - #16
Merged
Merged
Conversation
Per-token pretexts (masked point modeling) read `tokens` and never need the pooled event embedding, so cls now defaults to None. The one consumer that requires it -- CURTAIN's QueryCrossAttnEncoder -- guards for None with a clear error. Existing backbones still fill cls, so behavior is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The cls=None guard raises ValueError; add the matching Raises section so pydoclint (DOC503) passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make
EncodedEvent.clsoptional (Tensor | None = None).A backbone with no event-level readout can now leave
clsunset, and per-token pretexts that read onlytokensdon't have to synthesize one. The single consumer that actually needs it — CURTAIN'sQueryCrossAttnEncoder— guards forNonewith a clear error.Existing backbones (DeepIce, DeepIceRope) still fill
cls, so behavior is unchanged.🤖 Generated with Claude Code