Make multi_json compatible with json 3.x - #67
Conversation
|
To handle RuboCop preventing |
Ref: https://github.com/ruby/json/releases/tag/v3.0.0.rc1 Unknown keyword arguments will raise `ArgumentError`. - `quirks_mode:` no longer existing since json 2.0 (~2011). - `create_additions` no longer existing in json 3.0.
I don't thin that would be enough, as the constraints would still apply. I did submit a PR to rubocop which was merged, hopefully it's released soon. |
|
@sferik sorry to be a bother, but could I request a new release? I released |
|
Hello! Since |
|
@byroot No bother. I will cut a new @vpellan Can you say a bit more about why you’d like support for Ruby 3.0 and 3.1? As you’re probably aware, support for Ruby 3.0 ended over 2 years ago. There are several known security vulnerabilities that are unpatched in the latest 3.0.7 and 3.1.7 releases. If it’s important to you to run the latest version of If I go ahead with this backport, how much longer would you expect me to support Ruby 3.0 and 3.1? The |
Bump the version to 1.21.2 and add the changelog section covering the changes since 1.21.1: json 3.x support in the json_gem adapter (#67), the JRuby adapter preference reorder that puts json_gem ahead of jrjackson, and the fix for a falsy :pretty option (#70). Update the README adapter preference table to match the new JRuby order, since it still listed jrjackson first.
|
|
Ref: https://github.com/ruby/json/releases/tag/v3.0.0.rc1
Unknown keyword arguments will raise
ArgumentError.quirks_mode:no longer existing since json 2.0 (~2011).create_additionsno longer existing in json 3.0.NB: rubocop prevent installing the RC, so I only did some local testing after messing with the Gemfile.