Add variant of geins taking insertion mode to C interface#39
Open
fdrmrc wants to merge 1 commit into
Open
Conversation
Owner
|
Is this ready for review? |
Contributor
Author
Yes, let me remove the draft status. I am not yet entirely sure about the approach, though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends
psb_c_dgeinsallowing an explicit mode argument, namedpsb_c_dgeins_options. The signature isThe intent of this is to allow the insertion mode to be specified per-call rather than at allocation time. If the caller tries to switch between insert and add within the same assembly round, an exception is thrown. This is the behavior of
VecSetValues()in PETSc: https://petsc.org/release/manualpages/Vec/VecSetValues/An example of this possible usage is the following, where the
xhvector is updated after assembly.I am not sure this is the best way to achieve the desired result, hence its draft status. It is also implemented here for double types only.
Here is minimal working example that tests its correct usage: mwe.c