Skip to content

Persist a validated preview width preference - #321

Closed
PathGao wants to merge 1 commit into
sftwrdotdev:fix/enable-preview-task-checkboxesfrom
PathGao:feat/preview-width-preference
Closed

Persist a validated preview width preference#321
PathGao wants to merge 1 commit into
sftwrdotdev:fix/enable-preview-task-checkboxesfrom
PathGao:feat/preview-width-preference

Conversation

@PathGao

@PathGao PathGao commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Part of #263.

Adds one normalized, persistent preview-width preference: default 880 px, clamped to 640–1600 px, with invalid values recovering to the default. It deliberately does not reuse the Monaco wrapping-column setting.

The following UI/layout PR will consume this preference for preview width, Full mode, ToC geometry, and print-safe behavior.

This is stacked after #320 and its predecessors. Merge the predecessor chain first.

Validation

  • npm run check (0 errors, 0 warnings)
  • npm test (142 passing)
  • npm run build

Post-Deploy Monitoring & Validation

No additional operational monitoring required: this commit only adds a local preference with deterministic validation. Owner: maintainer; validate persisted values, invalid localStorage recovery, and reset behavior in the follow-up UI PR.

@PathGao

PathGao commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

@alecdotdev This is the first focused #263 PR. It is stacked after #320 and its predecessors; please review in that order. The follow-up will wire this preference into Settings, preview layout, ToC geometry, and print behavior.

@PathGao
PathGao force-pushed the feat/preview-width-preference branch from 0e0f64f to dc75e0a Compare August 2, 2026 05:43
@PathGao
PathGao changed the base branch from master to fix/enable-preview-task-checkboxes August 2, 2026 05:44
@PathGao

PathGao commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by native Stack PR #346 (Stack #353). Closing this fork-head PR so #346 is the active review path.

@PathGao PathGao closed this Aug 2, 2026
@PathGao
PathGao deleted the feat/preview-width-preference branch August 2, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant