fix(test): master is red — retire the iframe allowlist entry #388 made stale - #398
Merged
Merged
Conversation
…e stale sftwrdotdev#397 shipped the "YouTube links never become embedded frames" rule with one allowlist entry for `replaceWithYoutubeEmbed` in MarkdownViewer.svelte, an uncalled pre-fix leftover it could not delete because sftwrdotdev#388 owned that file. Its comment said to delete the copy and the entry together. sftwrdotdev#388 deleted the copy; the entry stayed, so the marker now matches nothing and the meta-test that catches stale rules fires - correctly. The rule was always meant to be "allowed nowhere", which is now true. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mastercurrently failsnpm test:This is my mistake, and the mechanism is worth naming. #397 shipped that rule with one allowlist entry covering
replaceWithYoutubeEmbedinMarkdownViewer.svelte— an uncalled pre-fix leftover it could not delete, because #388 owned that file. Its comment said to delete the copy and the entry together. #388 deleted the copy; the entry stayed.#397's CI was green before #388 landed, and it merged without re-running against the newer base. A green measured on an older base is not a green for the merge.
The rule was always meant to be "allowed nowhere" — that is now literally true, so the entry goes and the rule joins the other nowhere-rule, which the meta-test correctly skips. The rule now guards the whole tree instead of all-but-one file.