[MoonEP] Destroy communication buffers on runtime reset - #35834
Draft
musclemuller wants to merge 2 commits into
Draft
musclemuller wants to merge 2 commits into
musclemuller wants to merge 2 commits into
Conversation
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of #35783.
MoonEP communication buffers own NVLink/VMM resources and already expose explicit destruction, but
reset_context()currently drops the runtime resource store without invoking that cleanup. This draft makes reset/test teardown deterministic for the communication-buffer path already present on themoonepbranch.This is intentionally the first narrow lifecycle PR. It does not cover the symmetric weight pool from #34874, observability, autotuning, model reload, production graceful shutdown, or GPU/multi-rank teardown validation.
Modifications
Resources.reset_context().MoonEPBuffer.destroy_all_buffers()when the process-local MoonEP buffer state is first created.Accuracy Tests
Not applicable. This change does not alter model outputs or the dispatch/combine data path.
Speed Tests and Profiling
Not applicable. Cleanup runs only from
reset_context(); no inference hot path was changed.Tests
test/registered/unit/test_runtime_context.py: 72 passed, 35 subtests passed. The local environment used an import-only stub for the unrelated optionaldatasetsdependency during collection.test/registered/unit/layers/moe/test_moonep_buffer.py: 9 passed.F401,F821,UP037),git diff --check, andscripts/ci/check_registered_tests.pypassed.GPU and multi-rank teardown validation has not been run for this draft.
Checklist
CI States
Latest PR Test (Base): ❌ Run #32463957071
Latest PR Test (Extra): ❌ Run #32463956581
Latest PR Test (AMD ROCm 10): ❌ Run #32463956855