Skip to content

Fix buyer name to sentence case #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebm5025 merged 1 commit into from
Aug 1, 2026
Merged

Fix buyer name to sentence case #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/services/openDkpService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,9 +687,10 @@ export const openDkpService = {

// Collect items from this tick
for (const loot of tick.data.loot) {
const buyer = toSentenceCase(loot.buyer);
const odkpItem = await openDkpService.getItem(loot.item);
if (!characters.find((c) => c.Name === loot.buyer)) {
const errorMsg = `${loot.buyer} won ${odkpItem.ItemName} on tick ${tick.name}, but is not a registered character. Item will not be uploaded.`;
if (!characters.find((c) => c.Name === buyer)) {
const errorMsg = `${buyer} won ${odkpItem.ItemName} on tick ${tick.name}, but is not a registered character. Item will not be uploaded.`;
failures.push(errorMsg);
log(errorMsg);
} else {
Expand All @@ -699,7 +700,7 @@ export const openDkpService = {
);
}
items.push({
CharacterName: loot.buyer,
CharacterName: buyer,
Dkp: loot.price,
ItemName: odkpItem.ItemName,
GameItemId: odkpItem.GameItemId,
Expand Down
Loading