Fix RLS bypass via nested VALUES subquery - #3
google-labs-jules[bot] wants to merge 2 commits into
Conversation
This change addresses a vulnerability where Row Level Security (RLS) could be bypassed by nesting a subquery within a VALUES clause. The existing `traverse_scope` logic in `sqlglot` did not reliably extract tables from such constructs. The fix adds an explicit traversal of `exp.Values` nodes in `extract_tables_from_statement` to find any hidden tables, while employing a heuristic to avoid extracting Common Table Expressions (CTEs) as physical tables. Added `tests/unit_tests/sql/parse_tests_vulnerability.py` to verify the fix. Existing tests in `tests/unit_tests/sql/parse_tests.py` pass.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change addresses a vulnerability where Row Level Security (RLS) could be bypassed by nesting a subquery within a VALUES clause. The existing `traverse_scope` logic in `sqlglot` did not reliably extract tables from such constructs when the SQL expression was processed raw (e.g., in certain Query datasource paths). The fix adds an explicit traversal of `exp.Values` nodes in `extract_tables_from_statement` to find any hidden tables, while employing a heuristic to avoid extracting Common Table Expressions (CTEs) as physical tables. Added `tests/unit_tests/sql/parse_tests_vulnerability.py` to verify the fix. Existing tests in `tests/unit_tests/sql/parse_tests.py` pass.
Fixed an RLS bypass vulnerability involving nested subqueries in VALUES clauses by enhancing table extraction logic in
superset/sql/parse.py.PR created automatically by Jules for task 161568805393635571 started by @sha174n