Skip to content

Added ability to extend exec environment variables #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VojtechBartos wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Added ability to extend exec environment variables #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2bbdb2
Removing white space on the end of the line
VojtechBartos Oct 31, 2015
b72a1c1
Added option to extend process env variables with exec options param
VojtechBartos Oct 31, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/ansible.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ AbstractAnsibleCommand.prototype.exec = function(options) {
processOptions.cwd = options.cwd;
}

// Make Ansible output unbuffered so the stdout and stderr `data` events
// Make Ansible output unbuffered so the stdout and stderr `data` events
// pickup output up more regularly
var unbuffered = (options.buffered) ? '' : 1;
processOptions.env = process.env;
_.extend( processOptions.env, { PYTHONUNBUFFERED: unbuffered } );
_.extend( processOptions.env, options.env || {} );
Copy link
Copy Markdown
Owner

@shaharke shaharke Dec 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_.extend can accept multiple objects as sources. Please fix the code to look like this:

_.extend( processOptions.env, options.env, { PYTHONUNBUFFERED: unbuffered } );


var output = '';
var child = exec.spawn(this.commandName(), this.compileParams(), processOptions);
Expand Down