feat: record reasons for dispute resolutions - #481
Merged
Conversation
Implement the dispute-resolution reason feature requested in the issue. What changed: - Add the serializable ResolutionReason enum with ProofValid, ProofInvalid, ProofLate, InsufficientEvidence, and MutualSettlement variants. - Extend resolve_dispute with an optional reason argument and use ProofValid or ProofInvalid as sensible defaults when omitted. - Extend batch_resolve_disputes so each resolution can carry its own optional reason. - Persist the selected reason under a versioned per-shipment and per-milestone storage key. - Add get_dispute_resolution_reason for off-chain and contract consumers to query the recorded reason. - Extend the legacy dispute_resolved tuple by appending the reason while retaining all existing outcome fields. - Add the reason to the structured dispute_resolved event without changing its existing keys. - Preserve meaningful defaults for timeout, panel, finality, and mediation resolution events. This closes the issue requiring arbiter decisions to expose why they were made while keeping outcome-only consumers compatible. Tests were intentionally not run per request.
|
@Joyyyb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the dispute-resolution reason feature requested in the issue.
What changed:
This closes the issue requiring arbiter decisions to expose why they were made while keeping outcome-only consumers compatible. Tests were intentionally not run per request.
Closes: #370