Remove MqttEnvironment.isWebClient and implement proper fix for issue168#191
Merged
Merged
Conversation
…e168` The original fix was more of a hack involving multiple buffer copies and global variable to guide code paths. The new fix is only one line change in MqttBrowserConnection. The internal buffer size of Uint8Buffer may be larger than Uint8Buffer.length and that was the culprit of the original issue. The rest of the changes are just reverting the original fix and cleaning up.
shamblett
added a commit
that referenced
this pull request
Feb 15, 2026
…e168` (#191) (#192) The original fix was more of a hack involving multiple buffer copies and global variable to guide code paths. The new fix is only one line change in MqttBrowserConnection. The internal buffer size of Uint8Buffer may be larger than Uint8Buffer.length and that was the culprit of the original issue. The rest of the changes are just reverting the original fix and cleaning up. Co-authored-by: Juergen Werner <pogojotz@gmx.net>
Owner
|
Great thanks, merged, package re published at version 4.15.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original fix was more of a hack involving multiple buffer copies and global variable to guide code paths.
The new fix is only one line change in
MqttBrowserConnection. The internal buffer size ofUint8Buffermay be larger thanUint8Buffer.lengthand that was the culprit of the original issue.The rest of the changes are just reverting the original fix and cleaning up.