Adding comments and sensible defaults to all.sample#25
Adding comments and sensible defaults to all.sample#25syed wants to merge 3 commits intoshapeblue:masterfrom
Conversation
|
I've also added SSH keys support so when you spin up VMs, Trillian will automatically add its ssh keys so that ansible can work. This is required for any public images as the root account is disabled for most of them. you will have to specify |
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
@syed it turns out I don't have rights to merge. I chase getting those. In the meanwhile; I see a lot of hardcoding of values that used to be placeholders. Does it make sense to move those "defaults" to comments, to discourage their use?
| def_env_use_sec_groups: yes | ||
| def_env_prihost: "<IP_ADDRESS_HERE>" | ||
| def_env_sechost: "<IP_ADDRESS_HERE>" | ||
| def_env_use_sec_groups: yes # BEING DEPRECATED: |
There was a problem hiding this comment.
did something go wrong here?
| # BEING DEPRECATED: | ||
| def_env_zone_secgroups: "false" | ||
|
|
||
| def_env_zone_secgroups: "false" # BEING DEPRECATED: |
There was a problem hiding this comment.
@DaanHoogland This is me basically reordering the comment. As per my discussion with Paul, he mentioned that these were being removed. However the placement of that comment made me think that everything after that was be depricated so I moved it to just that line that was being depricated.
|
@DaanHoogland @PaulAngus anything needed from my side to merge this? |
|
H @syed, yes. conflict resolution and the undoing of the changes in the sample file where place holders are filled with real values. |
|
Ok. I will get to that this weekend :) |
2 participants
Hi @PaulAngus . As per our conversation last Friday, I am adding more comments in the all.sample file with some defaults. Let me know if I got them all right