Skip to content

Conversation

@gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 27, 2026

Description

Spotted those when once again testing the feature with akschual funds as a user and this didn't look right:

  • Information overload when withdrawing, i.e doesn't make sense to see APY, est. yearly returns, or interest accrual explainers when withdrawing - did keep the immediate/delayed exit explainer as it does make absolute sense for withdraws
  • Also noticed a bug when all is currently being unstaked (e.g for ATOM, but really for any with delayed unstaked that need to be finalized): able to click unstake but shouldn't be able to, as there's nothing to unstake

This PR fixes both!

Issue (if applicable)

closes #

Risk

Low - UI-only changes: filtering explainers by action type and disabling unstake button when no active balance.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

No protocol/transaction changes. Affects yield position card UI and withdraw/exit modal explainers.

Testing

Engineering

  • Navigate to a yield position with all balance in exiting/pending state (e.g. ATOM staking)
  • Confirm Unstake button is disabled with tooltip: "No active balance available to unstake."
  • Confirm Unstake button is enabled when there IS active staked balance
  • Open withdraw/exit modal and confirm APY, est. yearly returns, and interest accrual explainers are hidden
  • Confirm the immediate/delayed exit explainer still shows in withdraw modal
  • Open deposit/enter modal and confirm all explainers still show as before

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Screenshot 2026-01-26 at 21 01 15 Screenshot 2026-01-26 at 21 05 14 Screenshot 2026-01-26 at 21 18 45 image

gomesalexandre and others added 2 commits January 26, 2026 21:03
Hide APY and estimated yearly earnings when withdrawing since they're
irrelevant for exit actions. Filter yield explainers by action relevance
so exit modal only shows withdraw/unbonding info, not deposit info.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat_yield_unstaking_polish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gomesalexandre gomesalexandre marked this pull request as ready for review January 27, 2026 07:26
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 27, 2026 07:26
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespaces off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants