Skip to content

Conversation

@atdrendel
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings September 24, 2025 14:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes lifecycle event observation functionality for the SQLiteDatabase class and adds conditional compilation to prevent app lifecycle notifications from being registered on Mac Catalyst.

  • Removes observeLifecycleEvents parameter from database initialization methods
  • Updates conditional compilation to exclude Mac Catalyst from UIKit-based lifecycle handling
  • Always calls registerForAppNotifications() without conditional logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@atdrendel
Copy link
Contributor Author

@myobie I merged your pull request. Then, after pulling that change into the iOS app, I thought to myself, when would anyone ever want to listen to those lifecycle events on Mac Catalyst? So, I figured I'd just remove them here inside of SQLite and remove the need for the extra argument and compilation condition inside of our iOS app.

@atdrendel atdrendel merged commit 24d5f3f into main Sep 24, 2025
1 check passed
@atdrendel atdrendel deleted the ignore-lifecycle-events-on-mac branch September 24, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants