Search admin users by id#144
Open
GHX5T-SOL wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the work. Will be reviewing it soon :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Search admin users by id
Summary
Addresses #80.
Validation
go test ./internal/api -run TestAdminListUsers -count=1go test ./internal/storage -count=1git diff --check HEAD~1 HEADgit show --format= --patch HEAD | gitleaks stdin --no-banner --redact --timeout 30Notes
go test ./internal/api -run TestAdminListUsers_SearchMatchesUserID -count=1failed withtotal: got 0, want 1.go test ./internal/api -count=1; it failed in unrelated existing tests such asTestFirstbootKeyServedOnceGlobally,TestAdminConfigShape,TestListAPIKeys, andTestScenario_SwarmOrchestrator. The new user-search regression passed during that run.