feat(ui): flow Home fronting cards into a grid on wide screens - #48
Merged
Conversation
Home's fronting list was a single column, so on a tablet or landscape it left most of the width empty. Switch it to an adaptive grid (one column on phones, two or more as the window widens) and exempt Home from the content-width cap so the grid gets the whole width to lay columns across. Announcements and the bottom spacer span the full row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #47 (large-screen layout). That PR merged just before this commit landed on the branch, so the Home grid missed the boat - this carries it over on its own.
What
Home's fronting list was a single column, so on a tablet or landscape it left most of the width empty even after #47's pillar-box fix. It's now an adaptive grid:
Home opts out of #47's content-width cap (
FULL_BLEED_ROUTES) so the grid gets the whole width to lay columns across rather than being capped to a single centred column's worth. Announcements and the bottom spacer span the full row.Testing
:app:assemblePlayReleasegreen (through R8). Device checklist:Follow-up (not here)
ListDetailPaneScaffold.