fix(vcs-core): reuse resolved driver schema during exec#39
Open
mturac wants to merge 1 commit into
Open
Conversation
Contributor
|
Hello, thank you for your contribution! I'll try to review this later today. |
Author
|
Validation refreshed on the current head: git diff --check origin/main...HEAD
uv run pytest vcs-core/packages/core/tests/unit/test_binding_surface.py::test_vcscore_exec_uses_cached_resolved_binding_contract_without_runtime_describe -q
uv run pytest vcs-core/packages/core/tests/unit/test_binding_surface.py -q
uv run pytest vcs-core/packages/core/tests/unit/test_base_substrate_driver.py vcs-core/packages/core/tests/integration/vcscore/test_commands.py -q
uv run ruff check vcs-core/packages/core/src/vcs_core/_substrate_driver.py vcs-core/packages/core/src/vcs_core/_vcscore_runtime.py vcs-core/packages/core/src/vcs_core/_world_transition_coordinator.py vcs-core/packages/core/tests/unit/test_binding_surface.py
uv run --package vcs-core --group typing mypy vcs-core/packages/core/src/vcs_core/_substrate_driver.py vcs-core/packages/core/src/vcs_core/_vcscore_runtime.py vcs-core/packages/core/src/vcs_core/_world_transition_coordinator.pyAll passed locally. The current ruff/gates/macOS test checks are also green on this head. |
88a746c to
18bde94
Compare
18bde94 to
3935c6d
Compare
Author
|
Rebased this branch onto the current git diff --check origin/main...HEAD
cd vcs-core/packages/core && uv run --group test pytest tests/unit/test_binding_surface.py -q
cd vcs-core/packages/core && uv run --group lint ruff check src/vcs_core/_substrate_driver.py src/vcs_core/_vcscore_runtime.py src/vcs_core/_world_transition_coordinator.py tests/unit/test_binding_surface.py
cd vcs-core/packages/core && uv run --group lint ruff format src/vcs_core/_substrate_driver.py src/vcs_core/_vcscore_runtime.py src/vcs_core/_world_transition_coordinator.py tests/unit/test_binding_surface.py --diff
cd vcs-core/packages/core && uv run --group typing mypy src/vcs_core/_substrate_driver.py src/vcs_core/_vcscore_runtime.py src/vcs_core/_world_transition_coordinator.py
make -C vcs-core/packages/core test PYTEST_XDIST= TEST_FILE=tests/unit/test_binding_surface.pyAll pass locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VcsCore.execdispatch validationdriver.describe()fallback for callers that do not pass a cached schemaFixes #11.
Validation
uv run pytest vcs-core/packages/core/tests/unit/test_binding_surface.py::test_vcscore_exec_uses_cached_resolved_binding_contract_without_runtime_describe -quv run pytest vcs-core/packages/core/tests/unit/test_binding_surface.py -quv run pytest vcs-core/packages/core/tests/unit/test_base_substrate_driver.py vcs-core/packages/core/tests/integration/vcscore/test_commands.py -quv run ruff check vcs-core/packages/core/src/vcs_core/_substrate_driver.py vcs-core/packages/core/src/vcs_core/_vcscore_runtime.py vcs-core/packages/core/src/vcs_core/_world_transition_coordinator.py vcs-core/packages/core/tests/unit/test_binding_surface.pyuv run --package vcs-core --group typing mypy vcs-core/packages/core/src/vcs_core/_substrate_driver.py vcs-core/packages/core/src/vcs_core/_vcscore_runtime.py vcs-core/packages/core/src/vcs_core/_world_transition_coordinator.py