Skip to content

Fix: Add support for Hermes Agent#43

Open
MayVerse4 wants to merge 1 commit into
shepherd-agents:mainfrom
MayVerse4:fix/fix-add-support-for-hermes-agent
Open

Fix: Add support for Hermes Agent#43
MayVerse4 wants to merge 1 commit into
shepherd-agents:mainfrom
MayVerse4:fix/fix-add-support-for-hermes-agent

Conversation

@MayVerse4

Copy link
Copy Markdown

Autonomously generated fix for issue.

Note: The agent reached its maximum step limit before explicitly passing code review.

Fixes #13

@ananjan-nandi-9

Copy link
Copy Markdown
Collaborator

Hey @MayVerse4, thanks for picking this up!

I took a quick look and there are a few issues with this PR as it stands:

  • CI is failing. There's a duplicated def codex_provider_result_from_payload( line in providers.py, so the module won't import.
  • The flags don't match the actual hermes CLI. It doesn't have -p or --output-format json; oneshot mode is -z, and the result comes back through --usage-file. Hermes exits 0 even when a run fails, so the return code alone can't tell you whether it worked.
  • This could use some test coverage.

Also want to be upfront with you: we have our own implementation ongoing for the Hermes provider (I left a note on #13 with what it covers). Sorry about not marking the issue as being worked on, we're still pretty new to maintaining an open-source repo. Once our version is up we'll link it here and sort out where that leaves this PR. In the meantime, happy to answer any questions as you work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Hermes Agent

2 participants