Skip to content

Chore/docs and test cleanup#127

Closed
JTL-lab wants to merge 33 commits into
mainfrom
chore/docs_and_test_cleanup
Closed

Chore/docs and test cleanup#127
JTL-lab wants to merge 33 commits into
mainfrom
chore/docs_and_test_cleanup

Conversation

@JTL-lab
Copy link
Copy Markdown
Collaborator

@JTL-lab JTL-lab commented May 28, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

mschertzer and others added 30 commits May 4, 2026 18:35
…ME_REFERENCE

Previously, params.protein_fasta was used for both GENCODE and custom protein
FASTAs, causing header parsing failures when a custom/LRP FASTA was passed into
the GENCODE slot (expected 8-field pipe-delimited headers).

Changes:
- Rename params.protein_fasta to params.custom_protein_fasta
- Add params.lrp_protein_fasta for pre-computed LRP proteomes (proteomics-only runs)
- GENCODE protein FASTA (pc_translations.fa) now auto-resolved from --genome via gencode_refs
- BUILD_PROTEOME_REFERENCE module input tuple expanded from 4 to 5 elements
  (lrp_fasta, counts, custom_fasta, gencode_protein_fasta)
- Each FASTA passed as named arg to R script (--lrp_fasta, --custom_fasta, --gencode_fasta)
- GENCODE protein FASTA decompression gated on protein samples, not RNA samples
- Add gencode_refs entries for v40-v42; fix v45 protein_fasta URL pointing to v46
- Fix FragPipe workflow file missing trailing newline (upstream Nesvilab #2730)
…flexible FASTA/GTF inputs to NOVEL_PEPTIDES

Previously, peptide-to-genome BED mapping only ran when the full LRP
pipeline was executed end to end. GENCODE and custom/LRP BED mapping
now run independently based on their own inputs.

- Replace --lr_cds_gtf/--lr_orf_fasta with --custom_fasta, --custom_gtf,
  --gencode_fasta, --gencode_gtf in novel_peptides.R and module
- Add params.lrp_gtf and params.custom_gtf for proteomics-only runs
- Fallback chain: pipeline output > --lrp_gtf/fasta > --custom_gtf/fasta
  (mirrors BUILD_PROTEOME_REFERENCE pattern)"
- Add LSF scheduler configuration.
- Resolve FASTA database path inside container at runtime in FragPipe 
  module. Path was previously resolved at Nextflow script generation 
time, which could produce a path not accessible inside the 
Apptainer/Singularity container. Switched to printf with $(pwd) for 
runtime resolution.
- Replace heredoc with echo statements for versions.yml generation in
  FragPipe module to avoid indentation-sensitive parsing failures.
…ptional run parameters for slurm or lsf configs
…erence support, species-based hexamer model selection for CPAT, fix overwrite bug with RNA samples metadata for MULTISAMPLE_ANALYSIS triggered by running multiple datasets in same repository
…m value if provided, but otherwise ensure pipeline halts if user provides custom GTF and FASTA but does not set --species value
…sier run mode and suppression of second token being sent to user email when running on HPC
…exit status immediately fails pipeline (bypass issues related to module failing on HPC clusters but pipeline not terminating)
…STA for genome FASTA and GTF do not run when only protein samples with PROTEOMICS runs, modify channel setup in main workflow so that only RNA subworkflow processes shown in interactive mode when running with only RNA samples and vice versa with protein samples
…gtf and --gencode_fasta to --gtf and --fasta
…ollowing deprecated --fasta param removal, simplify container directives for isocall modules to avoid issue with unbound task variable when running with only singularity
…king speedup proportional to cpus allocated, bump PROCESS_LONG tag up to 4 cpus by default to support chunking optimization
…long-running Fragpipe processes for large datasets
…single-sample column naming to match multi-sample name format of FL.{sample_id}
@JTL-lab JTL-lab closed this May 28, 2026
@JTL-lab JTL-lab deleted the chore/docs_and_test_cleanup branch May 28, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants