Mention PBox2D -> Box2DProcessing in README.md#30
Open
eggsyntax wants to merge 1 commit intoshiffman:mainfrom
Open
Mention PBox2D -> Box2DProcessing in README.md#30eggsyntax wants to merge 1 commit intoshiffman:mainfrom
eggsyntax wants to merge 1 commit intoshiffman:mainfrom
Conversation
Author
|
(alternately if Box2D is long-outdated and there's some other physics engine lib that everyone uses these days, I'd be grateful to know that :) ) |
Author
|
Update: everything else seems to be working well, although it might be worth naming some of the necessary imports -- I've been finding them as I go along by searching this repo. The ones I've needed so far are import shiffman.box2d.*;
import org.jbox2d.dynamics.*;
import org.jbox2d.common.Vec2;
import org.jbox2d.collision.shapes.*; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Daniel! Thanks so much for your work on Box2D-for-Processing, and for making the Nature of Code book freely available (I think I actually bought a copy when it came out, but it's been a long time...). I just tried to set up a project based on the book and tripped over the PBox2D class being unavailable, and found in the Processing forum that it'd been replaced by Box2DProcessing.
PR just makes brief mention of that in the README. It may be that there are other changes that have to be taken into account; if I stumble across more I'll try to create PRs for them as I have time.
Thanks again!