feat: store acquire token as promise for multi access - #2
Open
TheVaan wants to merge 1 commit into
Open
Conversation
Author
|
Hi @shigeyf, any chance that this PR could be merged or rejected promptly? This issue is blocks my work and I have to decide wether implementing the solution in my code if this gets rejected. |
Author
|
Bump.... |
TheVaan
force-pushed
the
feat/stored-acquire-token-promise
branch
from
March 1, 2024 10:01
c3c1314 to
ed79585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I had some trouble with concurrent calls of
acquireToken(). This results from multiple api calls done from my Vue app simultanious. First, I was confused why some of the calls ofacquireTokennot updating the result value until I found out, the method blocks itself from being called while already called and not finished.I figured out a workaround by saving the promise what results in getting exactly the same promise while not finished processing. I think this workaround should be the default behavior because it's hard to figure out why
useMsalAuthentication()sresultisundefinedwithout a deep-dive into the source code.Cheers!