Remove the unrepaired linux_x86_64 OpenMC wheels - #25
Merged
Conversation
These eight wheels are local "python -m build" output from before the cibuildwheel workflows existed, added in Feb and Apr 2025. The linux_x86_64 tag means they never went through auditwheel repair, so they carry no openmc.libs directory and libopenmc.so still links against the build machine's libhdf5.so.310, libdagmc.so, libMOAB.so.5, libfmt.so.6 and libpugixml.so.1. They only import on a machine that already has the whole OpenMC dependency stack. On a current system pip never selected them anyway, since manylinux_2_28_x86_64 outranks linux_x86_64 in the tag priority list and both files carry the same version. The case where pip did select them is the harmful one: on glibc older than 2.28 the manylinux wheel is not a candidate, so pip fell through to the unrepaired wheel, installed it, and left the user with an ImportError on first use. Removing them turns that into a clean "no matching distribution found". Regenerates openmc/index.html with update_indexs.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the eight
linux_x86_64tagged OpenMC wheels and regeneratesopenmc/index.html.openmc-0.15.3-cp310-cp310-linux_x86_64.whl65afccc, Apr 2025openmc-0.15.3-cp311-cp311-linux_x86_64.whl65afccc, Apr 2025openmc-0.15.3-cp312-cp312-linux_x86_64.whl65afccc, Apr 2025openmc-0.15.3-cp313-cp313-linux_x86_64.whl65afccc, Apr 2025openmc-0.15.3-cp314-cp314-linux_x86_64.whl65afccc, Apr 2025openmc-0.15.1.dev0-cp310-cp310-linux_x86_64.whl0e551f3, Feb 2025openmc-0.15.1.dev0-cp311-cp311-linux_x86_64.whl0e551f3, Feb 2025openmc-0.15.1.dev0-cp312-cp312-linux_x86_64.whl0e551f3, Feb 2025Why
They are local
python -m buildoutput from before the cibuildwheel workflows existed. Thelinux_x86_64tag is the giveaway: they never went throughauditwheel repair, so there is noopenmc.libs/directory in them (3.3 MB each against 33 MB for the manylinux equivalents) andlibopenmc.sostill links straight at the build machine's environment:So they only import on a machine that already has the full OpenMC dependency stack installed.
On any current system pip never picked them regardless:
manylinux_2_28_x86_64sits at tag priority index 15 against 42 forlinux_x86_64, and the competing files carry the same version, so tag priority decided it.The case where pip did pick them is the one worth fixing. On glibc older than 2.28 (CentOS 7, Ubuntu 18.04) the manylinux_2_28 wheel is not a compatible candidate at all, so pip fell through to the unrepaired wheel, installed it happily, and the user hit an
ImportErrorforlibhdf5.so.310on the firstimport openmc. With these gone, that platform gets a clean "no matching distribution found" instead, which is the honest answer for it.README.mdonly ever documented the manylinux files, so no doc changes are needed.check-index.ymlshould pass, asupdate_indexs.pywas rerun and leaves no dangling references.Left in place, for a possible follow up
openmc-0.15.3-cp310-cp310-manylinux_2_28_x86_64.whlships 32 MB of stray simulation output inside the package directory (statepoint.1000.h5,statepoint.100.h5,summary.h5,weight_windows.h5), picked up from the working directory of that June 2025 build. Itslinux_x86_64twin had the same problem and is deleted here.openmc-0.15.1.dev0-*-manylinux_2_28_x86_64.whlfiles are superseded by 0.15.3 and unreachable in practice, since pip ignores pre-releases by default.requires-python = ">=3.12", so those wheels cannot be rebuilt from current develop.