Skip to content

Add X handle linking to Shipwright's handle to the navbar#208

Merged
openshift-merge-bot[bot] merged 1 commit intoshipwright-io:mainfrom
Dinesht04:FEAT-109
Mar 30, 2026
Merged

Add X handle linking to Shipwright's handle to the navbar#208
openshift-merge-bot[bot] merged 1 commit intoshipwright-io:mainfrom
Dinesht04:FEAT-109

Conversation

@Dinesht04
Copy link
Copy Markdown
Contributor

@Dinesht04 Dinesht04 commented Mar 9, 2026

Changes

Added X's ICON linking to shipwright's official X handle to the navbar.
image
image

Fixes #109

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Signed-off-by: Dinesht04 <dineshtyagi567@gmail.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2026
Copy link
Copy Markdown
Member

@IrvingMg IrvingMg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2026
@IrvingMg
Copy link
Copy Markdown
Member

@shipwright-io/approvers PTAL

Copy link
Copy Markdown
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 6a210a7 into shipwright-io:main Mar 30, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this to Done in Issues Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add LinkedIn and twitter page and custom icon too in footer

4 participants