Skip to content

Add authCookieName option for mercure - #189

Merged
acelaya merged 1 commit into
shlinkio:mainfrom
acelaya-forks:mercure-1-improvements
Oct 11, 2026
Merged

acelaya merged 1 commit into
shlinkio:mainfrom
acelaya-forks:mercure-1-improvements

Conversation

@acelaya

@acelaya acelaya commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Part of shlinkio/shlink#2671

Yet another PR to expand on the integration with Mercure 1.0, after #186, #187 and #188

This one adds one extra option so that people can let Shlink know what is the cookie name set in Mercure Hub for the auth token.

This will be later used to expose to web clients, so that they can set the right cookie when subscribing to updates.

Additionally, it renames the MercureVersion cases from v0 and v1 to legacy and stable, so that it is future-proof for later mercure stable versions..

@acelaya
acelaya force-pushed the mercure-1-improvements branch from a7fca22 to 33fc865 Compare October 11, 2026 07:57
@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.31%. Comparing base (ed5162b) to head (33fc865).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #189   +/-   ##
=========================================
  Coverage     99.31%   99.31%           
- Complexity      183      184    +1     
=========================================
  Files            49       49           
  Lines           581      585    +4     
=========================================
+ Hits            577      581    +4     
  Misses            4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acelaya
acelaya merged commit 349d779 into shlinkio:main Oct 11, 2026
9 checks passed
@acelaya
acelaya deleted the mercure-1-improvements branch October 11, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant