Repository navigation
Add authCookieName option for mercure - #189
Merged
Merged
Conversation
acelaya
force-pushed
the
mercure-1-improvements
branch
from
October 11, 2026 07:57
a7fca22 to
33fc865
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=========================================
Coverage 99.31% 99.31%
- Complexity 183 184 +1
=========================================
Files 49 49
Lines 581 585 +4
=========================================
+ Hits 577 581 +4
Misses 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of shlinkio/shlink#2671
Yet another PR to expand on the integration with Mercure 1.0, after #186, #187 and #188
This one adds one extra option so that people can let Shlink know what is the cookie name set in Mercure Hub for the auth token.
This will be later used to expose to web clients, so that they can set the right cookie when subscribing to updates.
Additionally, it renames the MercureVersion cases from
v0andv1tolegacyandstable, so that it is future-proof for later mercure stable versions..