Skip to content

Fix redis connections left open sometimes - #2663

Merged
acelaya merged 2 commits into
shlinkio:developfrom
acelaya-forks:predis-fix
Sep 21, 2026
Merged

acelaya merged 2 commits into
shlinkio:developfrom
acelaya-forks:predis-fix

Conversation

@acelaya

@acelaya acelaya commented Sep 21, 2026

Copy link
Copy Markdown
Member

Closes #2658

Require shlink-common 9.0.2, whcih in turn requires predis 3.6.1

@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.18%. Comparing base (3f08c5e) to head (951daf6).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2663   +/-   ##
==========================================
  Coverage      94.17%   94.18%           
  Complexity      1605     1605           
==========================================
  Files            273      273           
  Lines           5017     5023    +6     
==========================================
+ Hits            4725     4731    +6     
  Misses           292      292           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acelaya
acelaya merged commit 4a8fee4 into shlinkio:develop Sep 21, 2026
31 of 32 checks passed
@acelaya
acelaya deleted the predis-fix branch September 21, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale Redis connection permanently poisons a RoadRunner worker

1 participant