Sanitize UI & escaping; persist edits; API tweak#8
Merged
Conversation
Add input/output sanitization and escaping across draft and review UIs, improve status class handling, and make edit persistence more robust. Changes include: - Backend: refine_explanation now returns a merged refined_question with detailed_explanation and model/timestamp metadata. - UI: store pipeline config on load for DraftController use. - Add escapeHtml and sanitizeRenderedHtml helpers to prevent XSS and strip dangerous attributes/tags from rendered HTML/Markdown. - Escape IDs, filenames, status messages and other user-provided strings when injecting HTML to DOM. - Normalize status-based class names via statusClassName to avoid invalid CSS classes. - DraftController: derive paperCode from filename, use pipelineConfig default subject, and ensure safe IDs in generated cards and action buttons. - ReviewController: escape editable fields when rendering, sanitize Markdown output before inserting into DOM, and sanitize preview content. - saveCurrentEdits: changed to support force saves, guard against missing draft data, and only save when needed. - Publish/refine flows now await saves; acceptAll/rejectCurrentQuestion made async and properly await publish/save operations. refineQuestion handling updated to accept either a full refined_question or fallback to updating generated_content.detailed_explanation. These changes aim to harden the UI against XSS, ensure consistent class names, and make the save/publish/refine flows more reliable.
shmukit
approved these changes
Jun 8, 2026
shmukit
left a comment
shmukit
left a comment
Owner
There was a problem hiding this comment.
Why we should approve:
-
Critical Security Fix: Rendering unescaped strings and raw Markdown into .innerHTML left the viewer application exposed to XSS payloads through malicious document content or metadata. The sanitization additions address this risk.
-
Eliminates Race Conditions: The change ensures that user-edited fields are actually saved to the database before subsequent actions are processed.
-
Improves Consistency: Storing pipeline configuration and cleaning up class names prevents UI layout bugs and hardcoded fallback assumptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add input/output sanitization and escaping across draft and review UIs, improve status class handling, and make edit persistence more robust.