refactor/remove scss dependencies#1187
Draft
Arnold Stoba (arnoldstoba) wants to merge 3 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Fix the icon dimension CSS to emit `px` units and ship it under a stable filename (`meteor-icon-kit.css`). - Stop generating the SCSS stylesheet (BREAKING: import the `.css` instead of the `.scss`). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Convert all SCSS (nesting, variables, lighten/darken) to plain CSS with native nesting, meteor tokens, and logical properties; move z-index/shadow into a local tokens.css. - Drop the sass dependency, Vite SCSS config, and *.scss sideEffect. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Arnold Stoba (arnoldstoba)
force-pushed
the
refactor/remove-scss-dependencies
branch
from
191ac7a to
fc24403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the SCSS/Sass dependency from the component library and switches the icon kit from a generated SCSS stylesheet to pure CSS. Two commits: a breaking
icon-kitchange (major) and an internalcomponent-libraryrefactor (patch).Why?
The design system already moved to CSS custom properties synced from Figma (
@shopware-ag/meteor-tokens), so the leftover Sass dependency added build complexity for almost no benefit (only ~1 SCSS variable and a few legacy colors were still used). Dropping it gives us plain, modern CSS and removes a build dependency. The icon kit's generated.csswas also buggy (emitted unitlesswidth: 20;), so it got fixed along the way.How?
icon-kit (breaking, major):
pxunits and ship it under a stable filename (meteor-icon-kit.css), dropping the content-hashed name.…/meteor-icon-kit.cssinstead of…/meteor-icon-kit.scss.component-library (patch):
lighten()/darken()) to plain CSS using native nesting, meteor semantic tokens, and CSS logical properties.assets/css/tokens.css;assets/scss/all.scss→assets/css/all.css.sassdependency, the Vite SCSS preprocessor config, and the*.scsssideEffect; repointed the global + Storybook imports at the CSS entry.Testing?
build,lint:css(0 errors), and unit tests pass in both packages.meteor-icon-kit.cssis byte-identical to what a fresh sync produces.Anything Else?
shopware/shopware: removing the icon-kit.scssis a breaking change — its import likely needs updating to the.css.--color-text-brand-hover/-pressed), which also gives these spots automatic dark-mode support they previously lacked — worth a quick visual sanity check.mt-data-table.vuewas converted to flat selectors (rather than nested) given its size and JS-coupled sticky/scroll logic; its JS-driven positional properties were intentionally kept physical.