fix: The pauseThreshold was being mutated directly onto the asset obj…#86
Open
fix: The pauseThreshold was being mutated directly onto the asset obj…#86
Conversation
…ect (richCaptionAsset['pauseThreshold'] = 5), but the SDK's ResolvedClipSchema uses @shotstack/schemas which has .strict() mode — rejecting unknown keys.
…ring drag still fires every 100ms, so the caption visually re-flows live as you drag the edge handle.
…ut the canvas schema defaults to "middle".
…with branch prefix for conventional commits
…olor when no active property is set. The "with-active" variants verify only the active word changes color/scale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ect (richCaptionAsset['pauseThreshold'] = 5), but the SDK's ResolvedClipSchema uses @shotstack/schemas which has .strict() mode — rejecting unknown keys.