Skip to content

Performance improvement for large texts with many HTML spans #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpoetzsch wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Performance improvement for large texts with many HTML spans #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11b6aa2
added very slow performance test
Jan 18, 2024
001125a
huge performance improvement for large texts with many spans (~20x)
Jan 18, 2024
6483564
simplification
Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/subParsers/makehtml/hashHTMLSpans.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ showdown.subParser('makehtml.unhashHTMLSpans', function (text, options, globals)
'use strict';
text = globals.converter._dispatch('makehtml.unhashHTMLSpans.before', text, options, globals).getText();

var replacedSpans = [];

for (var i = 0; i < globals.gHtmlSpans.length; ++i) {
var repText = globals.gHtmlSpans[i],
// limiter to prevent infinite loop (assume 10 as limit for recurse)
Expand All @@ -50,9 +52,17 @@ showdown.subParser('makehtml.unhashHTMLSpans', function (text, options, globals)
}
++limit;
}
text = text.replace('¨C' + i + 'C', repText);

replacedSpans.push(repText);
}

// It is important to only do one replace for all the spans combined.
// Otherwise this gets really slow on large texts with many spans because
// of all the string copies.
text = text.replace(/¨C(\d+)C/g, function (_wm, num) {
return replacedSpans[num];
});

text = globals.converter._dispatch('makehtml.unhashHTMLSpans.after', text, options, globals).getText();
return text;
});
Loading