barcodes: README audited against the code - #328
Merged
Merged
Conversation
Every claim checked against main: the QR speed range reads from the race table (1.7 to 5.5x), the corpus sentence carries the measured mean and the slowest image's warm time, nativeEvery is described as the gate applies it (1 never forces the native search), the lock colors are the literal defaults, the ECI table is shared by QR and PDF417 only, the encoder is pinned against generated vectors rather than a shipped oracle, the probes paragraph states each probe's exact scope, and the race describes the misc/rip-prior checkout as main. The bench prints the README's row names verbatim, the race's baseline column is labeled rip main, and the PDF417 result type carries vertical, reversed and inverted as the reader sets them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twelve documentation defects found by an audit of packages/barcodes/README.md against the code on main, eight of them older than #327: the QR speed range, the corpus timing sentence, the nativeEvery description, lock color defaults, which symbologies share the ECI table, the encoder verification claim, the probes' stated scopes, and the race section's description of the misc/rip-prior checkout. The bench now prints the README's row names verbatim so the tables have one source, the race labels its baseline column rip main, and the PDF417 result type gains the three orientation fields the reader sets. 46 tests pass; a fresh bench run's rows match the README's rows exactly.