scripts: a lane that starts between two ticks of the live runner has spent nothing yet - #411
Merged
Merged
Conversation
…spent nothing yet, so its bar, its color and the run's share stay in range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bun run test:tuistopped on its first real run withrip/tui: color: "#14cf116" is not a color.The board reads its time once a clock tick, and a lane stamps its start as it arrives, so a lane that starts between two ticks had spent a negative time for one frame. Its fill went below zero, the cyan-to-green gradient extrapolated past the end of the range (a channel of 278), and the run's share went negative too — the terminal's progress indicator would have refused -0.1 next.
A lane's time spent is at least zero, in its row and in the run's share, and the gradient clamps its position to 0–1. A pin in
packages/tui/test/live.ripstarts a lane after the board's last tick and holds that the frame draws, with no color of seven digits; it fails without the fix.