revdiff-planning plugin Windows launcher (PowerShell + WezTerm)

[shtirlitsDva]

Task: revdiff-planning plugin Windows launcher (PowerShell + WezTerm)

Description

Mirror task 003's PowerShell port for the second plugin: plugins/revdiff-planning/. The bash launcher launch-plan-review.sh is ~335 lines with the same multi-terminal pattern; the PowerShell sibling targets only WezTerm via wezterm cli spawn --new-tab.

This task is structurally identical to task 003 but operates on a different file tree. It can run in parallel with 003 (no shared files) or be done immediately after 003 once the WezTerm spawn pattern is settled.

Acceptance Criteria

• plugins/revdiff-planning/scripts/launch-plan-review.ps1 created.
• plugins/revdiff-planning/scripts/launch-plan-review.sh is byte-identical to master — no edits.
• The planning plugin's SKILL.md (or whatever loader file dispatches to the script) includes a platform branch: PowerShell on Windows, bash elsewhere.
• launch-plan-review.ps1 accepts the same arguments as the bash version and forwards them to revdiff.exe (or whatever binary the plugin spawns).
• WezTerm spawning uses wezterm cli spawn --new-tab — same pattern as task 003.
• Temp files use $env:TEMP (New-TemporaryFile).
• Sentinel/wait pattern uses file polling — no mkfifo.
• try { } finally { } cleanup blocks guarantee no orphan tabs or temp files.
• Set-StrictMode -Version Latest and $ErrorActionPreference = 'Stop'.
• Header comment links to the bash sibling.
• Argument forwarding uses array form (@($arg1, $arg2)) — no string-interpolation injection.
• Macos/Linux flow via launch-plan-review.sh is unchanged.

Technical Details

Files to create

• plugins/revdiff-planning/scripts/launch-plan-review.ps1 — ~140 lines (slightly smaller than 003's launcher; mirror its structure).

Files to modify

• The planning plugin's SKILL.md (path to be confirmed during implementation; the plugin lives at plugins/revdiff-planning/ and the audit didn't enumerate every file inside it). Add the same $IsWindows dispatch block used in task 003.

Files to read (do not modify)

• plugins/revdiff-planning/scripts/launch-plan-review.sh — read top-to-bottom. Identify:
  1. Argument signature.
  2. WezTerm code path (port that, drop the rest).
  3. Exit conventions.
  4. Env vars expected from Claude.
• plugins/revdiff-planning/SKILL.md (if it exists) — find where the dispatch goes.
• .claude-plugin/skills/revdiff/scripts/launch-revdiff.ps1 (from task 003 if it landed first) — reuse the same WezTerm spawn helper structure to keep both PowerShell launchers consistent. Do not factor a shared helper module — the PRD scope is sibling files, not new shared infrastructure.

Notes

• If task 003 has not yet landed when this task starts, base the WezTerm spawn pattern on the design in 003's task file (Technical Details → "WezTerm spawn pattern").
• Keep the two .ps1 launchers visually similar so a future contributor can diff them mentally. Resist the urge to extract a shared helper unless both files end up >200 lines.
• The plugin version bump that closes this work happens in task 006 — do not bump plugin.json or marketplace.json here.

Audit references

• plugins/revdiff-planning/scripts/launch-plan-review.sh:1 — bash shebang
• plugins/revdiff-planning/scripts/launch-plan-review.sh:27,54,83,100,103,136,139 — mktemp /tmp/... calls to replace
• The WezTerm-specific path inside the bash file — find by searching for wezterm in the script

Dependencies

• None for creation — can start in parallel with task 001 and task 003.
• For validation, requires task 001 (working revdiff.exe).
• Validation in task 006 requires this task to be complete.

Effort Estimate

• Size: M (slightly smaller than 003)
• Scope: ~140 lines of PowerShell + a small SKILL.md edit. Single PR.

Definition of Done

• launch-plan-review.ps1 created
• Planning plugin SKILL.md dispatch updated
• Bash file in the same directory is byte-identical to master
• Manual smoke test on Windows + WezTerm: invoke the planning skill from a Claude Code session, confirm a new tab opens and the planning review renders
• Manual smoke test on macOS: invoke the planning skill, confirm bash path still runs
• Code reviewed

[shtirlitsDva]

Implementation landed on epic/windows-support. 2 commits:

• cac9678 Issue revdiff-planning plugin Windows launcher (PowerShell + WezTerm) #5: add launch-plan-review.ps1 PowerShell launcher targeting WezTerm
• 1b8106e Issue revdiff-planning plugin Windows launcher (PowerShell + WezTerm) #5: dispatch planning hook launcher selection on platform

Note on dispatch location: the revdiff-planning plugin has no SKILL.md — only hooks/hooks.json, scripts/launch-plan-review.sh, and scripts/plan-review-hook.py. The Python hook file is the actual loader that constructs the launcher invocation, so the platform dispatch went there (sys.platform == 'win32' selects launch-plan-review.ps1 and runs it via pwsh -NoProfile -ExecutionPolicy Bypass -File, with powershell fallback). Functionally equivalent to issue #4's SKILL.md dispatch.

Validation: launch-plan-review.ps1 parses clean under pwsh. plan-review-hook.py parses clean under python -c 'import ast; ast.parse(...)'. Bash file is byte-identical to master.

Will be closed after task #7 validation.