Skip to content

chore: increase httpx timeout to 15 minutes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shtratos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: increase httpx timeout to 15 minutes #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/claude_code_memory_proxy/proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class HttpClient:
def __init__(self, base_url: str) -> None:
self._client = httpx.AsyncClient(
base_url=base_url,
timeout=httpx.Timeout(60.0, connect=10.0, read=120.0),
timeout=httpx.Timeout(900.0, connect=30.0, read=900.0),
Copy link

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The httpx.Timeout constructor signature is Timeout(timeout=None, connect=None, read=None, write=None, pool=None) where the first positional argument is the default timeout. Setting both the default (900s) and read (900s) to the same value is redundant. Consider either using only the default timeout httpx.Timeout(900.0, connect=30.0) or explicitly setting write timeout as well if needed: httpx.Timeout(connect=30.0, read=900.0, write=900.0).

Suggested change
timeout=httpx.Timeout(900.0, connect=30.0, read=900.0),
timeout=httpx.Timeout(900.0, connect=30.0),

Copilot uses AI. Check for mistakes.
)

async def close(self) -> None:
Expand Down