Skip to content

Making crc32c defalut for download#60

Open
shubhangi-google wants to merge 4 commits into
mainfrom
making_crc32c_defalut_for_download
Open

Making crc32c defalut for download#60
shubhangi-google wants to merge 4 commits into
mainfrom
making_crc32c_defalut_for_download

Conversation

@shubhangi-google

Copy link
Copy Markdown
Owner

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.
  • Follow the instructions in CONTRIBUTING. Most importantly, ensure the tests and linter pass by running bundle exec rake ci in the gem subdirectory.
  • Update code documentation if necessary.

closes: #<issue_number_goes_here>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request changes the default verification method for file downloads from MD5 to CRC32C across the google-cloud-storage library and updates the corresponding tests. A review comment identifies an issue in project_anonymous_test.rb where the stubbed CRC32C value is set to a zero checksum ("AAAAAA==") instead of matching the actual file content ("yay!"), which will cause the download verification to fail.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@thiyaguk09 thiyaguk09 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants