feat(deployer): StateChangeLayer, DeploymentLogLayer, new log item structure#1171
Merged
chesedo merged 10 commits intoshuttle-hq:feat/shuttle-logger-servicefrom Sep 6, 2023
Conversation
jonaro00
force-pushed
the
feat/shuttle-logger-service
branch
2 times, most recently
from
cf9f0ad to
0255379
Compare
jonaro00
changed the title
jonaro00
force-pushed
the
feat/shuttle-logger-service
branch
from
557b9bd to
bb0c8c1
Compare
chesedo
reviewed
Aug 31, 2023
chesedo
reviewed
Sep 1, 2023
Contributor
chesedo
left a comment
chesedo
left a comment
There was a problem hiding this comment.
Nice, seems about done 🥳
Co-authored-by: Pieter <pieter@chesedo.me>
jonaro00
force-pushed
the
feat/shuttle-logger-service
branch
from
e0a97fe to
b06eaf8
Compare
jonaro00
changed the title
chesedo
reviewed
Sep 4, 2023
chesedo
reviewed
Sep 4, 2023
Contributor
chesedo
left a comment
chesedo
left a comment
There was a problem hiding this comment.
Nice, we just have to match the crash correctly and can then merge
oddgrd
reviewed
Sep 4, 2023
Collaborator
oddgrd
left a comment
oddgrd
left a comment
There was a problem hiding this comment.
Nice! Just a few small comments.
chesedo
approved these changes
Sep 5, 2023
Comment on lines
+31
to
+39
| pub const DEPLOYER_END_MSG_STARTUP_ERR: &str = "Service startup encountered an error"; | ||
| pub const DEPLOYER_END_MSG_CRASHED: &str = "Service encountered an error and crashed"; | ||
| pub const DEPLOYER_END_MSG_STOPPED: &str = "Service was stopped by the user"; | ||
| pub const DEPLOYER_END_MSG_COMPLETED: &str = "Service finished running all on its own"; | ||
|
|
||
| pub const DEPLOYER_END_MESSAGES_BAD: &[&str] = | ||
| &[DEPLOYER_END_MSG_STARTUP_ERR, DEPLOYER_END_MSG_CRASHED]; | ||
| pub const DEPLOYER_END_MESSAGES_GOOD: &[&str] = | ||
| &[DEPLOYER_END_MSG_STOPPED, DEPLOYER_END_MSG_COMPLETED]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
How has this been tested? (if applicable)