Upload Electron E2E failure artifacts#533
Open
yusufm wants to merge 3 commits intosiddharthvaddem:mainfrom
Open
Upload Electron E2E failure artifacts#533yusufm wants to merge 3 commits intosiddharthvaddem:mainfrom
yusufm wants to merge 3 commits intosiddharthvaddem:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds CI jobs: a ChangesE2E Testing Infrastructure
Hook Cleanup Refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 5/8 reviews remaining, refill in 22 minutes and 30 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/e2e/gif-export.spec.ts`:
- Around line 12-21: In waitForProcessExit (the async function using child:
ReturnType<ElectronApplication["process"]>) remove all checks of child.killed
and only treat child.exitCode !== null as the indicator the process has exited;
implement proper listener/timeout cleanup by registering concrete handlers
(e.g., onExit and onTimeout), using clearTimeout and child.removeListener in the
Promise.race resolution so no dangling listeners remain. Also update the SIGKILL
logic that currently gates on !child.killed (the guard around the kill attempt
referenced near the SIGKILL call) to instead check that child.exitCode === null
before sending SIGKILL so you always attempt to kill processes that haven't
actually exited.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0157bcfd-4958-4417-9beb-0925159ec055
📒 Files selected for processing (3)
.github/workflows/ci.ymlsrc/hooks/useScreenRecorder.tstests/e2e/gif-export.spec.ts
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/e2e/gif-export.spec.ts (1)
12-50: ⚡ Quick winMake the timeout distinguishable from a clean exit.
Lowkey risky:
waitForProcessExit()resolves on timeout exactly the same way it resolves after an actual exit, socloseElectronApp()can't tell whether Electron shut down or we just gave up and moved on. That can mask a stuck process and leave CI in a weird state.Consider returning a boolean or throwing when the forced-kill path still doesn't observe exit.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/e2e/gif-export.spec.ts` around lines 12 - 50, waitForProcessExit currently resolves both on real process exit and on timeout indistinguishably; change waitForProcessExit to return a boolean (true = observed exit before timeout, false = timed out) or to throw on timeout so callers can react. Update waitForProcessExit's internal promise to resolve(false) on the onTimeout path and resolve(true) on the onExit/finish path (or reject with an Error on timeout), and then update closeElectronApp to check the boolean/try-catch the rejection: if waitForProcessExit indicates a timeout, attempt child.kill("SIGKILL") and then throw if the second waitForProcessExit also fails (or propagate the timeout error) so stuck processes are surfaced instead of silently continuing; reference waitForProcessExit, closeElectronApp, child.exitCode, setTimeout, and child.kill in your changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@tests/e2e/gif-export.spec.ts`:
- Around line 12-50: waitForProcessExit currently resolves both on real process
exit and on timeout indistinguishably; change waitForProcessExit to return a
boolean (true = observed exit before timeout, false = timed out) or to throw on
timeout so callers can react. Update waitForProcessExit's internal promise to
resolve(false) on the onTimeout path and resolve(true) on the onExit/finish path
(or reject with an Error on timeout), and then update closeElectronApp to check
the boolean/try-catch the rejection: if waitForProcessExit indicates a timeout,
attempt child.kill("SIGKILL") and then throw if the second waitForProcessExit
also fails (or propagate the timeout error) so stuck processes are surfaced
instead of silently continuing; reference waitForProcessExit, closeElectronApp,
child.exitCode, setTimeout, and child.kill in your changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1e489961-5438-4992-b85d-231c9a676898
📒 Files selected for processing (1)
tests/e2e/gif-export.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Summary by CodeRabbit
Chores
Bug Fixes
Tests