Title: Fix Windows venv Python path resolution#122
Merged
siddu-k merged 3 commits intoMay 28, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates how the Electron main process determines which Python executable to launch, with improved handling for Windows virtual environments.
Changes:
- Add
fsdependency to verify the Python executable exists in a virtual environment. - Replace inline
pythonCmdresolution with aresolvePythonCmd()helper that checks for platform-specific venv paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<venv>/bin/python, which does not exist on Windows venvs.Scripts/python.exeon Windows andbin/pythonon other OSes, with a safe fallback to systempython/python3if the venv path is missing.VIRTUAL_ENVis set on Windows.Closes PR #120 @siddu-k