Skip to content

feat: add support for FriendlyElec CM3588 NAS#96

Merged
talos-bot merged 1 commit into
siderolabs:mainfrom
timoguin:feat/friendlyelec-cm3588-nas
Jan 13, 2026
Merged

feat: add support for FriendlyElec CM3588 NAS#96
talos-bot merged 1 commit into
siderolabs:mainfrom
timoguin:feat/friendlyelec-cm3588-nas

Conversation

@timoguin
Copy link
Copy Markdown

@timoguin timoguin commented Dec 5, 2025

This adds initial support for the CM3588 NAS, based on
the Rockchip RK3588 SoC. There is no SPI boot image in
upstream u-boot, so I left it out.

Changes:

  • Add friendlyelec-cm3588-nas build profile
  • Add u-boot artifacts
  • Add installer for board

Signed-off-by: Tim O'Guin timoguin@ohollow.tech

@timoguin timoguin force-pushed the feat/friendlyelec-cm3588-nas branch 2 times, most recently from 16db776 to 85d5a2c Compare December 5, 2025 01:12
@frezbo
Copy link
Copy Markdown
Member

frezbo commented Jan 5, 2026

@timoguin is this good to be merged?

@timoguin timoguin marked this pull request as ready for review January 5, 2026 17:18
@github-project-automation github-project-automation Bot moved this to To Do in Planning Jan 5, 2026
@talos-bot talos-bot moved this from To Do to In Review in Planning Jan 5, 2026
@timoguin
Copy link
Copy Markdown
Author

timoguin commented Jan 5, 2026

@timoguin is this good to be merged?

Hey, @frezbo. Same as my comment on #95, I just haven't figured out how to use imager for a full end-to-end test yet. Otherwise it's ready.

@timoguin timoguin force-pushed the feat/friendlyelec-cm3588-nas branch 2 times, most recently from b19f4a7 to dadb497 Compare January 9, 2026 01:43
@timoguin
Copy link
Copy Markdown
Author

timoguin commented Jan 9, 2026

@frezbo I tested this one using imager and was able to successfully boot from and install to SD card. All 4 drives are seen by Talos. I could test installing to eMMC as well, but I'd rather hold off on that if it's not a blocker to merging this. Just let me know.

However, I'm getting a randomized MAC address every time I reboot. I'm not sure how to fix that, but I think it's an issue with some of the other boards in this repo as well.

@github-project-automation github-project-automation Bot moved this from In Review to Approved in Planning Jan 13, 2026
This adds initial support for the CM3588 NAS, based on
the Rockchip RK3588 SoC. There is no SPI boot image in
upstream u-boot, so I left it out.

Changes:

- Add friendlyelec-cm3588-nas build profile
- Add u-boot artifacts
- Add installer for board

Signed-off-by: Tim O'Guin <timoguin@ohollow.tech>
Signed-off-by: Noel Georgi <git@frezbo.dev>
@frezbo frezbo force-pushed the feat/friendlyelec-cm3588-nas branch from dadb497 to 10e444d Compare January 13, 2026 13:58
@frezbo
Copy link
Copy Markdown
Member

frezbo commented Jan 13, 2026

/m

@talos-bot talos-bot merged commit 10e444d into siderolabs:main Jan 13, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Planning Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants