Fix handling for several SQL types on both RX/TX + add connection pools#78
Fix handling for several SQL types on both RX/TX + add connection pools#78noamw wants to merge 12 commits into
Conversation
|
Thanks! Can you make tests work as part of this PR? (I know they were broken before it, but still it's very uncomfortable to check PR's with failing tests) |
|
Unfortunately, I cannot dive into making the current test suite work. |
|
thanks, I like your tests. I'll try to add it to mysql-native and mysql2. Note that you are testing only LONGLONG type against different values in your int tests - |
|
also, big numbers tests don't actually check truncation as in javascript 18446744073709551615 === 18446744073709552000 is true. You need to keep input values as strings or bugnumber objects and compare results as strings |
Fix handling of Date objects, un/signed integers and binary buffers + adaptation of node-mysql pool