fix: remove hardcoded GCP project ID - #35
Open
Samybty wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Taskfile.yml in 03-installation-and-setup directory used a hardcoded GCP project ID in the Workload Identity configuration:
--workload-pool=kubernetes-course-424917.svc.id.goog
This only works for the original project.
When another user runs the task with their own GCP project, the cluster creation fails with an error similar to:
Currently, the only supported value for workload pool is ".svc.id.goog"
This error can be confusing, especially for beginners who are not familiar with YAML, Go Task, or GCP configuration.
Solution
This PR dynamically retrieves the currently configured GCP project ID:
vars:
GCP_PROJECT_ID:
sh: gcloud config get-value project 2>/dev/null
The cluster creation command then uses this variable:
--workload-pool={{.GCP_PROJECT_ID}}.svc.id.goog
Result
Each user can now create the cluster in their own GCP project without manually editing the Taskfile.yml.
This makes the configuration:
easier for beginners;
reusable with any GCP project;
less likely to fail because of a hardcoded project ID.
Testing
The following task now uses the active GCP project automatically:
task gcp:06-create-cluster