fix: add missing regex dependency#6
Merged
Conversation
The signwriting package depends on regex but doesn't pull it in transitively, causing the container to crash on startup with ModuleNotFoundError: No module named 'regex'. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AmitMY
approved these changes
Mar 12, 2026
Contributor
AmitMY
left a comment
AmitMY
left a comment
There was a problem hiding this comment.
Approved, but i am curious why CI did not fail beforehand...
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AmitMY
requested changes
Mar 12, 2026
| - name: Smoke test /health endpoint | ||
| run: | | ||
| docker run -d --name smoke -e PORT=8080 -e OPENAI_API_KEY=test -p 8080:8080 signwriting-description | ||
| for i in 1 2 3 4 5; do curl -sf http://localhost:8080/health && exit 0; sleep 2; done |
Contributor
There was a problem hiding this comment.
i guess no need for a for loop? just one run, and make sure it fails (i think you need --fail?)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AmitMY
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signwritingpackage depends onregexbut doesn't declare it as a transitive dependencyModuleNotFoundError: No module named 'regex'regexexplicitly topyproject.tomlfixes the issueTest plan
/healthreturns 200 with the fix🤖 Generated with Claude Code