Open
Conversation
jeffrey-signal
requested changes
Apr 14, 2026
Contributor
jeffrey-signal
left a comment
jeffrey-signal
left a comment
There was a problem hiding this comment.
I still need to get my test environment up and running in order to test this -- but it seems safe...
Has this been tested?
It violates the closed hierarchy guideline, because BufferedSink is a sealed interface. Technically implementing a sealed interface in a different package is allowed (unlike inheriting from a sealed class), but it's a bad idea. It is replaced by inlining the no-op OutputStream directly in DigestingRequestBody, accessed via a new method, `writeToNowhere`.
JesseWeinstein
force-pushed
the
remove_NowhereBufferedSink
branch
from
ff93ba7 to
67ed716
Compare
Contributor
Author
Looking into it further, I'm not sure how best to test this! It looks like it is used for uploading attachments and backup files, and only when it tries to resume an already uploaded file. Suggestions are welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
The
NowhereBufferedSinkclass violates the closed hierarchy guideline, becauseBufferedSinkis a sealed interface. Technically implementing a sealed interface in a different package is allowed (unlike inheriting from a sealed class), but it's a bad idea.It is replaced by inlining the no-op
OutputStreamdirectly inDigestingRequestBody, accessed via a new method,writeToNowhere.I still need to get my test environment up and running in order to test this -- but it seems safe...