feat(core): rename title to page title with a deprecation period - #257
Merged
vs-borodin merged 1 commit intoAug 30, 2026
Merged
Conversation
vs-borodin
approved these changes
Aug 30, 2026
Contributor
|
Thanks for jumping in! 🚀 @amirhosseinfaraji |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #255
Summary
Renames
title()topageTitle(). The old name still works, it's just deprecated now.As the issue says,
titledoesn't tell you which title you're getting. In one component you can easily have the route title, awebSharetitle and the document title in scope at the same time, andreadonly title = title()isn't nice to read.What changed
Added
@signality/core/router/page-titlewithpageTitle()andPageTitleOptions.@signality/core/router/titleis still there and still exported from the router barrel. It just callspageTitle()now, and bothtitle()andTitleOptionsgot@deprecated ... Will be removed in 1.0.I used the same wording asOnKeyOptions.passive, so it stays consistent.For the docs: new page at
/router/page-title, and the sidebar points there. I kept the old/router/titlepage with a deprecation notice instead of deleting it, so old links don't 404. I also fixed twowebShareexamples that hadreadonly title = title()in them, which is exactly the confusing case from the issue.Checklist
Breaking changes
None. Both old names keep working until 1.0. Migration is just a rename: