Skip to content

Bugfix: By default, MAC commands answers should only be sent once - #224

Merged
nondetalle merged 2 commits into
developfrom
ack-replay-fix
Sep 7, 2026
Merged

nondetalle merged 2 commits into
developfrom
ack-replay-fix

Conversation

@nondetalle

Copy link
Copy Markdown
Collaborator

Current default device behavior (i.e., resend MAC command answers until a downlink is received from the network) is wrong. According to LoRaWAN 1.0.4 specifications, this only applies to RXParamSetupAns, RXTimingSetupAns, TXParamSetupAns, and DlChannelAns, while all other uplink MAC commands are meant to be sent only once.

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.52%. Comparing base (67bcaef) to head (a159b5c).

Files with missing lines Patch % Lines
model/lora-frame-header.cc 47.05% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #224   +/-   ##
========================================
  Coverage    86.51%   86.52%           
========================================
  Files           68       68           
  Lines         7876     7880    +4     
========================================
+ Hits          6814     6818    +4     
  Misses        1062     1062           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nondetalle
nondetalle merged commit e45b4af into develop Sep 7, 2026
20 checks passed
@nondetalle
nondetalle deleted the ack-replay-fix branch September 7, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant