Gloas set AttestationData.index #9100
Merged
mergify[bot] merged 16 commits intosigp:unstablefrom Apr 26, 2026
Merged
Conversation
| { | ||
| self.canonical_head | ||
| .fork_choice_read_lock() | ||
| .is_payload_received(&beacon_block_root) |
Member
There was a problem hiding this comment.
This should check canonicity not just existence, I think. Spec says:
Set data.index = 1 to signal that the payload is present in the canonical chain (payload status is FULL in the fork-choice).
https://github.com/ethereum/consensus-specs/blob/master/specs/gloas/validator.md#attestation
Might need the canonicity code from:
Member
Author
There was a problem hiding this comment.
oh yeah, not sure how i mixed that up lol. thanks!
Member
There was a problem hiding this comment.
I've got a feeling this will be a common Gloas bug haha
eserilev
added
waiting-on-author
eserilev
added
ready-for-review
dapplion
approved these changes
Apr 26, 2026
Collaborator
dapplion
left a comment
dapplion
left a comment
There was a problem hiding this comment.
Logic is correct, good to go!
dapplion
added
ready-for-merge
Merge Queue Status
This pull request spent 27 minutes 57 seconds in the queue, including 26 minutes 39 seconds running CI. Required conditions to merge
|
10 tasks
dapplion
added a commit
to dapplion/lighthouse
that referenced
this pull request
Apr 28, 2026
PR sigp#9178 added this Gloas-only test using ApiTester::new() which produces a phase0 chain even under FORK_NAME=gloas, so head.beacon_state.get_ptc(...) errored with IncorrectStateVariant. After switching to new_with_hard_forks() three further issues surfaced: 1. The slot clock is left at head_slot + 1 by the harness setup, so a payload attestation for head_slot fails gossip propagation as a PastSlot. Rewind the clock to head_slot in make_valid_payload_attestation_message. 2. With VALIDATOR_COUNT = 32 and 32 slots/epoch, a slot's committees often hold only a single validator. The PTC for that slot then has one distinct validator regardless of PTCSize. The original test chained JSON and SSZ sub-tests on the same harness with ptc_offset 0 and 1 and asserted both gossip-published, but the second message is a duplicate (same slot/validator) and is silently dropped as PriorPayloadAttestationMessageKnown — so the second recv() hangs forever. Split the SSZ variant into its own test with its own harness so the two don't collide in the ObservedPayloadAttesters cache. 3. Switching the JSON test to new_with_hard_forks() so the chain actually reaches Gloas under FORK_NAME=gloas (same fix as the sibling tests added in sigp#8415 and sigp#9100). Verified locally: full Gloas suite 197/197 passed (350s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
For gloas
attestation.data.indexshould be set to 1 if we are attesting to a block whose slot is not the attestation duty slot and slot payload_status isFULL