Skip to content

Re-issue ForkchoiceUpdate based on updated PayloadStatus#9102

Merged
mergify[bot] merged 25 commits intosigp:unstablefrom
hopinheimer:re-issue-fcu-on-payload
Apr 25, 2026
Merged

Re-issue ForkchoiceUpdate based on updated PayloadStatus#9102
mergify[bot] merged 25 commits intosigp:unstablefrom
hopinheimer:re-issue-fcu-on-payload

Conversation

@hopinheimer
Copy link
Copy Markdown
Member

@hopinheimer hopinheimer commented Apr 6, 2026 •
edited
Loading

addresses #8957

implementation details

This PR adds the PayloadStatus to ProposerKey aiming to implicitly invalidate proposers cache, thus re-issuing FcU on cache miss. I haven't added the prepare_payload_lookahead change, we could potentially adjust that based on observations in devnet.

@hopinheimer hopinheimer added ready-for-review The code is ready for review fork-choice labels Apr 6, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 6, 2026

Some required checks have failed. Could you please take a look @hopinheimer? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Apr 6, 2026
@eserilev eserilev self-requested a review April 8, 2026 06:17
@hopinheimer hopinheimer added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 8, 2026
michaelsproul
michaelsproul reviewed Apr 9, 2026
View reviewed changes
Comment thread beacon_node/beacon_chain/src/beacon_chain.rs Outdated
michaelsproul
michaelsproul reviewed Apr 9, 2026
View reviewed changes
Comment thread beacon_node/beacon_chain/src/beacon_chain.rs Outdated
@eserilev
Copy link
Copy Markdown
Member

eserilev commented Apr 14, 2026

I think this may need to be re-worked a bit once we impl this new spec change https://github.com/ethereum/consensus-specs/pull/5094/changes

We wont have a StatePayloadStatus anymore

@michaelsproul
Copy link
Copy Markdown
Member

michaelsproul commented Apr 14, 2026

yeah I have deleted StatePayloadStarus on the fix-pruning-gloas branch

@jimmygchen jimmygchen added under-review A reviewer has only partially completed a review. and removed ready-for-review The code is ready for review labels Apr 15, 2026
michaelsproul
michaelsproul reviewed Apr 16, 2026
View reviewed changes
Comment thread beacon_node/beacon_chain/src/beacon_chain.rs
michaelsproul
michaelsproul reviewed Apr 16, 2026
View reviewed changes
Comment thread beacon_node/beacon_chain/src/beacon_chain.rs Outdated
michaelsproul
michaelsproul reviewed Apr 16, 2026
View reviewed changes
Comment thread beacon_node/execution_layer/src/lib.rs Outdated
@michaelsproul
Copy link
Copy Markdown
Member

michaelsproul commented Apr 21, 2026

Unblocked, but needs reconciling with:

The honest validator spec is likely somewhat relevant:

https://github.com/ethereum/consensus-specs/blob/v1.7.0-alpha.5/specs/gloas/validator.md#executionpayload

@mergify mergify Bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 22, 2026
@michaelsproul michaelsproul mentioned this pull request Apr 23, 2026
Closed
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 23, 2026

Some required checks have failed. Could you please take a look @hopinheimer? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Apr 23, 2026
@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 23, 2026
michaelsproul
michaelsproul approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core is ready to go. More tweaking is possible, but this PR definitely fixes some real problems and may help interop.

@eserilev eserilev added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 25, 2026
@eserilev
Copy link
Copy Markdown
Member

eserilev commented Apr 25, 2026

LGTM! we can always tweak things later, but this will definitely help for interop

@mergify mergify Bot added the queued label Apr 25, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 25, 2026 •
edited
Loading

Merge Queue Status

This pull request spent 28 minutes 50 seconds in the queue, including 26 minutes 57 seconds running CI.

Required conditions to merge

@eserilev
Copy link
Copy Markdown
Member

eserilev commented Apr 25, 2026

@mergify queue

@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 25, 2026

queue

☑️ This pull request is already queued

mergify Bot added a commit that referenced this pull request Apr 25, 2026
@mergify
Merge of #9102
a88f50b
@mergify mergify Bot mentioned this pull request Apr 25, 2026
Closed
10 tasks
@mergify mergify Bot merged commit df764ff into sigp:unstable Apr 25, 2026
39 checks passed
@mergify mergify Bot removed the queued label Apr 25, 2026
@michaelsproul michaelsproul mentioned this pull request Apr 30, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@eserilev eserilev eserilev approved these changes

@pawanjay176 pawanjay176 Awaiting requested review from pawanjay176

Assignees

No one assigned

Labels

fork-choice gloas ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hopinheimer @eserilev @michaelsproul @jimmygchen